Implement SecureStore class #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make minor copy edits for active voice, branding and deletion of extra spaces.
Currently the following commands in examples.py, do_import() do_deploy() do_versionning() do_clone() all return a success status (ie 0) irrespective of any errors originating from their sub-functions. This PR fixes this. Now these commands will return one of: 0 - success 1 - general failure x - failure returned by a subprocess.call function
subprocess.call() does not by default return a status value. Update the commands to add shell=True which forces a return value. Also convert the commands to a single string rather than a list as this plays more nicely with both linux and windows. Also fix a spurious :
Transport is a member of TLSSocket which is derived from TLSSocketWrapper. Make sure that TLSSocketWrapper::close() is called before the transport is destroyed.
TCP and UDP sockets are automatically available when mbed.h is included in an application. This change lets the TLSSocket be used in the same way.
Remove _thread suffix and rename threads.
Simplify the document. More information is provided on our documentation portal, link it here
davidsaada
force-pushed
the
david_securestore
branch
from
5d4a1bf to
705c29e
Compare
Fix off-by-one-error in BusIn/Out
Remove unnecessary commas, and standardize heading capitalization.
Remove unnecessary comma.
Remove unnecessary comma.
Increase EMAC test timeout to 1400 seconds
Add get_erase_value() support
Add names to system thread
Rollup PR for docs
…lehto/mbed-os into rollup
…/mbed-os into rollup
Rollup PR: Docs + small fixes
dannybenor
requested changes
Nov 7, 2018
Collaborator
dannybenor
left a comment
dannybenor
left a comment
There was a problem hiding this comment.
I reviewed securestore cpp and h
Fantastic Job!
Collaborator
There was a problem hiding this comment.
// Although name is not part of the data, we calculate CMAC on it as well
Collaborator
There was a problem hiding this comment.
you can use a bigger buffer, maybe 256 bytes
Owner
Author
There was a problem hiding this comment.
Good idea. Will check whether this has any effect on performance.
Collaborator
There was a problem hiding this comment.
Something strange at the end of this file
Owner
Author
There was a problem hiding this comment.
All I need here is to have the cipher and CMAC defines set. Nothing needed in the config.
Collaborator
|
There is a strange character at the end of the file... |
Owner
Author
|
Fixed all issues. Enlarging the scratch buffer indeed helped with the performance, but that's just because there were less calls to TDBStore. Seems like TDBStore is the problem. |
davidsaada
force-pushed
the
david_securestore
branch
from
705c29e to
a54c939
Compare
added 5 commits
November 7, 2018 15:30
davidsaada
force-pushed
the
david_securestore
branch
from
a54c939 to
4b6a2fe
Compare
davidsaada
pushed a commit
that referenced
this pull request
Jul 2, 2019
ARMC5 failed to compile the code with debug-profile (!!) as va_list is getting into std:: namespace when one includes <cstdarg>. Other compilers seem to be more relaxed, and so is ARMC5 if compiled with other profiles. Add the explicit std:: to references of va_list. While here, remove one extra copy of "#include "PlatformMutex.h"" and a "#include <stdarg.h>" which is kind of duplicate of "#include <cstdarg>". Error being fixed: --8<--8<--8<-- Compile [ 81.8%]: ATHandler.cpp [Error] ATHandler.h@552,0: #20: identifier "va_list" is undefined [Error] ATHandler.cpp@1226,0: ARMmbed#147: declaration is incompatible with "void mbed::ATHandler::handle_args(const char *, <error-type>)" (declared at line 552 of "./mbed-os/features/cellular/framework/AT/ATHandler.h") [ERROR] "./mbed-os/features/cellular/framework/AT/ATHandler.h", line 552: Error: #20: identifier "va_list" is undefined "./mbed-os/features/cellular/framework/AT/ATHandler.cpp", line 1226: Error: ARMmbed#147: declaration is incompatible with "void mbed::ATHandler::handle_args(const char *, <error-type>)" (declared at line 552 of "./mbed-os/features/cellular/framework/AT/ATHandler.h") ./mbed-os/features/cellular/framework/AT/ATHandler.cpp: 0 warnings, 2 errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SecureStore class.
@dannybenor @yossi2le @offirko @theamirocohen Please review.